refactor(otlp-exporter-base): promisify sendWithHttp#6434
Merged
pichlermarc merged 1 commit intoopen-telemetry:mainfrom Mar 4, 2026
Merged
Conversation
pichlermarc
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6434 +/- ##
=======================================
Coverage 95.69% 95.69%
=======================================
Files 364 364
Lines 11791 11793 +2
Branches 2748 2752 +4
=======================================
+ Hits 11283 11285 +2
Misses 508 508
🚀 New features to boost your workflow:
|
pichlermarc
force-pushed
the
refactor/http-transport-utils
branch
from
7b50a30 to
e99a62b
Compare
maryliag
approved these changes
Feb 26, 2026
JacksonWeber
approved these changes
Feb 26, 2026
trentm
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This change refactors sendWithHttp() to directly use a Promise instead of going through another callback, which reduces indirection and simplifies testing.
Fixes #5990